drewnoakes/metadata-extractor

PngMetadataReader - investigate if addDirectory call is redundant

Open

#414 opened on Jul 18, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (470 forks)batch import
buggood-first-issuehelp wanted

Repository metrics

Stars
 (2,411 stars)
PR merge metrics
 (Avg merge 3d 2h) (2 merged PRs in 30d)

Description

Is the addDirectory on line 180 redundant? It happens further down also outside of the catch.

https://github.com/drewnoakes/metadata-extractor/blob/81143f746e6774eb7625e374b3f6e56396288d1a/Source/com/drew/imaging/png/PngMetadataReader.java#L168-L185

Contributor guide

Research direction
Check if the addDirectory call on line 180 is redundant by comparing it with the call outside the catch block. Trace the execution flow in PngMetadataReader.
Tech stack
java
Domain
api
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75