drewnoakes/metadata-extractor

PngMetadataReader - investigate if addDirectory call is redundant

Open

#414 opened on Jul 18, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (2,411 stars) (470 forks)batch import
buggood-first-issuehelp wanted

Description

Is the addDirectory on line 180 redundant? It happens further down also outside of the catch.

https://github.com/drewnoakes/metadata-extractor/blob/81143f746e6774eb7625e374b3f6e56396288d1a/Source/com/drew/imaging/png/PngMetadataReader.java#L168-L185

Contributor guide

Tech stack
java
Domain
data
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaFamiliarity with metadata extractor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine line 180 of PngMetadataReader.java. Determine if the addDirectory call inside the catch block is redundant given that a subsequent addDirectory occurs later. Review the code flow and run existing tests after removing the line to verify no regression.