drewnoakes/metadata-extractor

Not returning the correct values on Canon Makernote

Open

#138 opened on Jan 6, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (2,411 stars) (470 forks)batch import
format-exifgood-first-issuehelp wantedimage-queue

Description

The changes made in #136 now reads the canon maker note but it doesn't return the correct value. For example for the linked pictures it returns 0 for lens type and empty string for lens model: IMG_1782 (Medium).JPG.zip piano.006.zip

Contributor guide

Tech stack
java
Domain
backenddata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaExif metadata knowledgeCanon Makernote format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the changes in PR #136 that introduced the Canon Makernote reading. Compare the output for the provided sample images with the expected values. Check the Canon Makernote specification for lens type and model tags. Review the code in the relevant reader class (likely CanonMakernoteDirectory or similar) to ensure proper tag mapping and decoding. Consider adding unit tests with the provided images.