dream-num/Luckysheet

[BUG]create()/destroy()/create() changes vertical scrollbar position

Open

#529 opened on Feb 19, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (15,390 stars) (2,236 forks)batch import
buggood first issue

Description

If an existing instance of Luckysheet is destroyed and then recreated with options containing new spreadsheet data, the new spreadsheet is scrolled to the bottom.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptDOM manipulationSpreadsheet API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the create() and destroy() methods in Luckysheet's source code, likely in src/core/luckysheet.js. The bug suggests that on destroy() the scroll position is not saved or reset. Look for any existing scroll state management and ensure that on re creation, the scroll position remains at the top or is restored properly. Check if there are any related issues or PRs linked in the comments (none visible). Consider testing with a clean instance creation after destroy.