dpkp/kafka-python

Only log warning about old SSL module when actually using SSL

Open

#925 opened on Dec 30, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Python (5,396 stars) (1,421 forks)batch import
help wanted

Description

related to #924

Personally, I'd prefer this warning only be logged if we're actually trying to use SSL. If we're just using PLAINTEXT connections, there's no need to warn about this.

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The warning is likely logged in the SSL related code (e.g., in `kafka/conn.py` or `kafka/protocol/ssl.py`). The contributor should find the `warn` or `logger.warning` call that mentions 'old SSL module' and wrap it in an `if` statement that checks whether the connection is using SSL (e.g., `if self.config.get('security protocol') != 'PLAINTEXT'`). Related issue #924 might provide additional details on the SSL module deprecation.