downshift-js/downshift

React.HTMLProps is not a thing in Flow

Open

#657 opened on Jan 29, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (980 forks)batch import
help wanted

Repository metrics

Stars
 (11,761 stars)
PR merge metrics
 (Avg merge 4d 9h) (7 merged PRs in 30d)

Description

Problem description:

Your Flow type definitions make use of React.HTMLProps, but this type doesn't exist in Flow.

https://github.com/paypal/downshift/blob/master/flow-typed/npm/downshift_v2.x.x.js.flow#L143

Suggested solution:

Maybe $Shape<HTMLSomething> will produce something similar.

Contributor guide

Research direction
The issue is that React.HTMLProps is not a valid Flow type. The suggested fix is to use $Shape<HTMLSomething> instead. The contributor should examine the file flow typed/npm/downshift v2.x.x.js.flow, specifically around line 143, and replace React.HTMLProps with an appropriate Flow type like $Shape<HTMLInputElement> or $Shape<HTMLSelectElement> depending on usage. They should verify the change by running Flow on the project and ensure no new type errors arise. It may also be helpful to review existing Flow type definitions in the repository for similar patterns.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Flow typingHTML element attributes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85