downshift-js/downshift

Multi-select useCombobox: VoiceOver bug when deselecting item

Open

#1555 opened on Nov 8, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (11,761 stars) (980 forks)batch import
bughelp wantedneeds investigation

Description

  • downshift version: 8.2.2
  • OS: macOS 13.6.1
  • Browser: Chrome 119.0.6045.123

Relevant code or config

The basic multiple selection combobox example: https://www.downshift-js.com/use-combobox/#basic-multiple-selection

What you did:

Deselect item

What happened:

After deselecting an item, VoiceOver moves to the first selected item in the list:

https://github.com/downshift-js/downshift/assets/7543552/4df98cd7-ad3c-4f9c-80ae-b52964afcab0

Reproduction repository:

Reproduces in the example: https://www.downshift-js.com/use-combobox/#basic-multiple-selection

Problem description:

I think VoiceOver should stay on the focused item even after deselecting it.

It works as expected in the Ariakit multi-select combobox: https://ariakit.org/examples/combobox-multiple

Suggested solution:

Contributor guide

Tech stack
javascripttypescriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactAccessibility (ARIA)downshift basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the useCombobox component's focus management when deselecting items. Examine the source code in downshift's useCombobox hook (likely in src/hooks/useCombobox.ts) to understand how the focus is moved after item removal. Compare with Ariakit's implementation for reference. Consider modifying the focus logic to keep focus on the deselecting item or shift focus appropriately for VoiceOver.