downshift-js/downshift

Fix test:flow:coverage and add it back to validate script

Open

#1367 opened on Mar 16, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (11,761 stars) (980 forks)batch import
chorehelp wanted

Description

  • downshift version: 6.1.7
  • node version: 16.13.2
  • npm (or yarn) version: 8.1.2

Relevant code or config

What you did:

Run "test:flow:coverage".

What happened:

Error like this https://github.com/rpl/flow-coverage-report/issues/208. Should be fixed by that repo probably.

Errors should be fixed and the command added back to validate script.

Contributor guide

Tech stack
javascriptreact
Domain
frontendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptnpm scripts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the flow coverage report issue linked in the error (https://github.com/rpl/flow coverage report/issues/208). The goal is to update or patch the dependency to fix the coverage script. Once resolved, add the 'test:flow:coverage' script back to the validate script in package.json. Look at the current validate script to know where to place it.