downshift-js/downshift

[useSelect] Selecting item with spacebar in firefox reopens the menu

Open

#1197 opened on Nov 18, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (11,761 stars) (980 forks)batch import
bughelp wantedneeds investigation

Description

  • downshift version: 6.0.6
  • firefox version: 82.0.3

Relevant code or config

Error present in reference implementation: https://www.downshift-js.com/use-select

What you did:

With firefox, open a menu and select an item with the spacebar key

What happened:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the __menu_keydown_space_button__ is emitted, and on key up the __togglebutton_click__ is emitted.

Error is not present in chrome.

Reproduction repository:

Problem description:

Suggested solution:

Contributor guide

Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicskeyboard events understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the event handling for the spacebar key in the useSelect hook, focusing on the difference between Firefox and Chrome. Look at the onKeyDown and onClick handlers, particularly how they interact. The issue mentions that in Firefox, keydown emits ' menu keydown space button ' and keyup emits ' togglebutton click ', which causes the menu to reopen. Check the source code in the downshift repository, likely in the useSelect.js file, to see if there is a missing event.preventDefault() or improper event propagation handling. Also, check if the 'onKeyUp' event needs to be suppressed. The reference implementation at https://www.downshift js.com/use select can be used for reproduction.