downshift-js/downshift

[useSelect] Selecting item with spacebar in firefox reopens the menu

Open

#1,197 opened on Nov 18, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (980 forks)batch import
bughelp wantedneeds investigation

Repository metrics

Stars
 (11,761 stars)
PR merge metrics
 (Avg merge 6d 9h) (5 merged PRs in 30d)

Description

  • downshift version: 6.0.6
  • firefox version: 82.0.3

Relevant code or config

Error present in reference implementation: https://www.downshift-js.com/use-select

What you did:

With firefox, open a menu and select an item with the spacebar key

What happened:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the __menu_keydown_space_button__ is emitted, and on key up the __togglebutton_click__ is emitted.

Error is not present in chrome.

Reproduction repository:

Problem description:

Suggested solution:

Contributor guide

Research direction
Investigate the event handling for spacebar keydown and keyup in Firefox vs Chrome, and ensure that the toggle button click event is not triggered after selection.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75