dotnet/wpf

Avoid calling Path.GetTempFileName

Open

#259 opened on Jan 11, 2019

View on GitHub
 (3 comments) (3 reactions) (0 assignees)C# (6,683 stars) (1,126 forks)batch import
:construction: work in progressEnhancement RequestedGood First Issue

Description

System.Windows.Input.Cursor.LoadFromStream may throw IOException. DevDiv\FX\Rel\Net471Rel1Last\wpf\src\Core\CSharp\System\Windows\Input\Cursor.cs calls Path.GetTempFileName which will throw if the %TEMP% directory contains too many temp files (65k).

Reported by customer as VS Feedback issue

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C#File I/O concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the file `DevDiv/FX/Rel/Net471Rel1Last/wpf/src/Core/CSharp/System/Windows/Input/Cursor.cs` to understand the current usage of Path.GetTempFileName. Check the 3 comments for any proposed solutions or maintainer guidance. Replace Path.GetTempFileName with a non throwing alternative like `Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())` and handle potential exceptions gracefully.