dotnet/winforms

Add unit tests to System.ComponentModel.Design.Serialization.* components

Open

#719 opened on Apr 9, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (4,100 stars) (922 forks)batch import
good first issuehelp wantedtest-enhancement

Description

Add unit tests (if not exists) for

  1. Methods:

System.ComponentModel.Design.Serialization.CodeDomSerializer

  • M:System.ComponentModel.Design.Serialization.CodeDomSerializer.#ctor
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializer.Deserialize(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializer.Serialize(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializer.SerializeMember(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object,System.ComponentModel.MemberDescriptor)

System.ComponentModel.Design.Serialization.ExpressionContext

  • M:System.ComponentModel.Design.Serialization.ExpressionContext.get_Expression
  • M:System.ComponentModel.Design.Serialization.ExpressionContext.get_PresetValue

System.ComponentModel.Design.Serialization.CodeDomSerializerBase

  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.DeserializeExpression(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.String,System.CodeDom.CodeExpression)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.GetExpression(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.GetUniqueName(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.SerializeCreationExpression(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object,System.Boolean@)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.SerializeEvents(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.CodeDom.CodeStatementCollection,System.Object,System.Attribute[])
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.SerializeProperties(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.CodeDom.CodeStatementCollection,System.Object,System.Attribute[])
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.SerializeToExpression(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object)
  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerBase.SetExpression(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object,System.CodeDom.CodeExpression)

System.ComponentModel.Design.Serialization.CodeDomComponentSerializationService

  • M:System.ComponentModel.Design.Serialization.CodeDomComponentSerializationService.#ctor(System.IServiceProvider)

System.ComponentModel.Design.Serialization.CollectionCodeDomSerializer

  • M:System.ComponentModel.Design.Serialization.CollectionCodeDomSerializer.#ctor

System.ComponentModel.Design.Serialization.CodeDomSerializerException

  • M:System.ComponentModel.Design.Serialization.CodeDomSerializerExceptionr.#ctor

System.ComponentModel.Design.Serialization.MemberCodeDomSerializer

  • M:System.ComponentModel.Design.Serialization.MemberCodeDomSerializer.#ctor
  • M:System.ComponentModel.Design.Serialization.MemberCodeDomSerializer.ShouldSerialize(System.ComponentModel.Design.Serialization.IDesignerSerializationManager,System.Object,System.ComponentModel.MemberDescriptor)
  1. Classes:
  • System/ComponentModel/Design/Serialization/CodeDomSerializer.cs
  • System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs
  • System/ComponentModel/Design/Serialization/ResourceCodeDomSerializer.cs
  • System/ComponentModel/Design/Serialization/RootContext.cs
  • System/ComponentModel/Design/Serialization/SerializeAbsoluteContext.cs
  • System/ComponentModel/Design/Serialization/StatementContext.cs

Epic: #716 Related issues: #221, #608, https://github.com/dotnet/winforms/issues/10135 Related PRs: #615

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#unit testing framework (xUnit)CodeDom serialization concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
This issue requests adding unit tests for several classes in the System.ComponentModel.Design.Serialization namespace. The files to test are listed in the issue body, including CodeDomSerializer.cs and others. Look at existing tests in the repository for patterns, and refer to related issues #221, #608, and PR #615 for context. Since this is part of epic #716, ensure alignment with the overall testing goals.