dotnet/winforms

Add unit tests to System.ComponentModel.Design.* components

Open

#715 opened on Apr 9, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (4,100 stars) (922 forks)batch import
good first issuehelp wantedtest-enhancement

Description

Add unit tests (if not exists) for

Methods: System.ComponentModel.Design.UndoEngine

  • M:System.ComponentModel.Design.UndoEngine.#ctor(System.IServiceProvider)
  • M:System.ComponentModel.Design.UndoEngine.DiscardUndoUnit(System.ComponentModel.Design.UndoEngine.UndoUnit)
  • M:System.ComponentModel.Design.UndoEngine.Dispose(System.Boolean)
  • M:System.ComponentModel.Design.UndoEngine.get_Enabled
  • M:System.ComponentModel.Design.UndoEngine.get_UndoInProgress
  • M:System.ComponentModel.Design.UndoEngine.GetService(System.Type)
  • M:System.ComponentModel.Design.UndoEngine.set_Enabled(System.Boolean)

System.ComponentModel.Design.DesignSurface

  • M:System.ComponentModel.Design.DesignSurface.add_Flushed(System.EventHandler)
  • M:System.ComponentModel.Design.DesignSurface.remove_Flushed(System.EventHandler)

System.ComponentModel.Design.InheritanceService

  • M:System.ComponentModel.Design.InheritanceService.#ctor
  • M:System.ComponentModel.Design.InheritanceService.IgnoreInheritedMember(System.Reflection.MemberInfo,System.ComponentModel.IComponent)

System.ComponentModel.Design.DesignerActionMethodItem

  • M:System.ComponentModel.Design.DesignerActionMethodItem.#ctor(System.ComponentModel.Design.DesignerActionList,System.String,System.String,System.String,System.String,System.Boolean)
  • M:System.ComponentModel.Design.DesignerActionMethodItem.#ctor(System.ComponentModel.Design.DesignerActionList,System.String,System.String,System.String,System.String,System.Boolean)
  • M:System.ComponentModel.Design.DesignerActionMethodItem.get_IncludeAsDesignerVerb
  • M:System.ComponentModel.Design.DesignerActionMethodItem.Invoke

System.ComponentModel.Design.DesignerActionPropertyItem

  • M:System.ComponentModel.Design.DesignerActionPropertyItem.#ctor(System.String,System.String,System.String)
  • M:System.ComponentModel.Design.DesignerActionPropertyItem.get_MemberName
  1. Classes:
  • System/ComponentModel/Design/DesignSurfaceServiceContainer.cs
  • System/ComponentModel/Design/DesignerActionItem.cs
  • System/ComponentModel/Design/DesignerActionList.cs
  • System/ComponentModel/Design/DesignerHost.cs
  • System/ComponentModel/Design/ExceptionCollection.cs
  • System/ComponentModel/Design/ExtenderProviderService.cs
  • System/ComponentModel/Design/HostDesigntimeLicenseContext.cs
  • System/ComponentModel/Design/LoadedEventHandler.cs
  • System/ComponentModel/Design/ReferenceService.cs
  • System/ComponentModel/Design/StatusCommandUI.cs

Epic: #716 Related issues: #221, #469, #592 Related PRs: #606

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#unit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the existing unit tests in the `tests` folder for patterns used in testing similar components. The issue lists specific methods and classes under `System.ComponentModel.Design` namespace. For each, determine if a test class exists and if not, create it. Look at the `UndoEngine`, `DesignSurface`, `InheritanceService`, `DesignerActionMethodItem`, and `DesignerActionPropertyItem` classes, and the classes listed. Use the same mocking and assertion styles as other tests in the repository. Also check the related PR #606 for previous work.