dotnet/winforms

DataGridView not dispose old elements

Open

#6,859 opened on Mar 17, 2022

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C# (922 forks)batch import
area-controls-DataGridViewhelp wantedtenet-performance

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (Avg merge 14d 22h) (56 merged PRs in 30d)

Description

  • .NET Core Version: all up to 7.0 p2

  • Have you experienced this same bug with .NET Framework?: Yes

Problem description: As I mentioned in https://github.com/dotnet/winforms/issues/6858 DataGridView not dispose old data on DataSource change. This is lead to 2 problems:

  1. All this stuff are going to finalization query because we have unnecessary finalizer here #6858.
  2. If we have a ContextMenuStrip bound to Cell/Column/Row we will have a memory leak. DataGridView with 3 columns and ContextMenuStrip bound to 1000 rows, result of DS refresh: image

Expected behavior: Old data must be property disposed. Probably in DataGridView.RefreshColumnsAndRows() (in DataGridView.Methods.cs)

Minimal repro: DataGridViewLeak.zip

Contributor guide

Research direction
Examine the DataGridView.RefreshColumnsAndRows() method in DataGridView.Methods.cs to understand where old data should be disposed, and ensure proper disposal when the DataSource changes.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#IDisposable pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70