dotnet/winforms

Update FolderNameEditor to use modern folder dialog

Open

#4,665 opened on Mar 9, 2021

View on GitHub
 (4 comments) (1 reaction) (0 assignees)C# (922 forks)batch import
area-DesignerSupporthelp wanted

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (Avg merge 14d 22h) (56 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

As noted here FolderNameEditor is using interop for folder selection, thus still opening the legacy folder dialog. FolderBrowserDialog has been updated to use the more modern Vista folder dialog. It would make sense to call FolderBrowserDialog from FolderNameEditor to get the same experience in the designer.

Also the InitialDirectory properties on FileDialog and FolderBrowserDialog should be annotated with FolderNameEditor to get the proper designer experience.

Describe the solution you'd like and alternatives you've considered

While the native interop could be updated to use the Vista dialog it probably makes more sense to just use the existing FolderBrowserDialog?

Will this feature affect UI controls?

  • their design time experience will be affected, but the designer should not require any changes
  • runtime experience will be affected if a property grid is used at runtime
  • accessibility/localization are unaffected

Contributor guide

Research direction
Examine FolderNameEditor.cs in the repository, particularly the interop call around line 131, and understand how FolderBrowserDialog is implemented. Propose replacing the interop with FolderBrowserDialog usage, ensuring the InitialDirectory property is annotated appropriately.
Tech stack
csharp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Windows Forms basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60