dotnet/winforms

The up and down arrows are not disabled when selecting the first or the last member in Images Collection Editor

Open

#3,152 opened on Apr 28, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (922 forks)batch import
:beetle: bug:construction: work in progresshelp wanted

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (Avg merge 14d 22h) (56 merged PRs in 30d)

Description

  • .NET Core Version: 5.0.100-preview.5.20227.13

  • Have you experienced this same bug with .NET Framework?: Yes

Problem description: The up and down arrows are not disabled when selecting the first or the last member. Core

Expected behavior: The up arrow should be disabled when selecting the first member. The down arrow should be disabled when selecting the last member. Designer

More info:

  1. This issue also can reproduce with .Net Core 3.1.
  2. This issue also can reproduce for MonthCalndar/ListView/TabControl/treeView controls.

Minimal repro:

  1. Create a winforms core project.
  2. Add a propertyGrid and a ImageList controls to form designer.
  3. Add this code in the construction method of form: propertyGrid1.SelectedObject = imageList1;
  4. Run the core project.
  5. Find the Images property of ImageList, click the Browser button to show the Images Collection Editor.
  6. Click the Add button to add 4 images in it, then select the last member.
  7. Observe the down arrows on the right of the images.

Or

  1. Run the attached project. TestApp.zip
  2. Do the above step 5-7.

Contributor guide

Research direction
Locate the code that manages the up/down arrow buttons in the Images Collection Editor. The arrows should be disabled when the selected index is at the first or last position. Check the logic that sets the enabled state of these buttons and ensure it correctly evaluates the selected index against the collection bounds.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NET
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80