dotnet/winforms

Don't force creation of `Handle` in `OnHandleCreated`

Open

#2,235 opened on Oct 29, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (922 forks)batch import
:beetle: bughelp wantedwaiting-on-team

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (Avg merge 14d 22h) (56 merged PRs in 30d)

Description

See https://github.com/dotnet/winforms/pull/2141

The base class Control.OnHandleCreated checks for IsHandleCreated and does nothing if the handle isn't created.

In other sub-classes, we do not check if (IsHandleCreated) before accessing this.Handle which forces creation. This leads to strange recursive behaviour as OnHandleCreated is called again.

My opinion is that we should fix this oversight in base classes to ensure that they don't create the Handle in OnHandleCreated if a Handle doesn't exist

Contributor guide

Research direction
Inspect the referenced PR (dotnet/winforms#2141) and review sub classes of Control that override OnHandleCreated to identify cases where Handle is accessed unnecessarily. Ensure conditional check for IsHandleCreated before accessing Handle.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NETWindows Forms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55