dotnet/winforms

[Dark Mode] ToolTip is not in dark mode after enabled SystemColorMode.Dark

Open

#11,954 opened on Aug 21, 2024

View on GitHub
 (2 comments) (2 reactions) (1 assignee)C# (4,100 stars) (922 forks)batch import
:construction: work in progressarea-DarkModehelp wanted

Description

.NET version

9.0.0-rc.1.24418.2 + private dlls built from winforms repo main branch

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: https://github.com/dotnet/winforms/pull/11857

Issue description

ToolTip is not in dark mode after enabled SystemColorMode.Dark image

Steps to reproduce

  1. Create a WinForms .NET application with checkBox and toolTip controls
  2. Find the ToolTip on toolTip1 property of checkBox, then set some text for this property
  3. Enable DarkMode by Application.SetColorMode(SystemColorMode.Dark) in Program.cs file
  4. Run application, tab or mouse over this checkBox to observe the keyboard tooltip or mouse tooltip

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsWinForms basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is that ToolTip does not respect dark mode when SystemColorMode.Dark is enabled. The dark mode feature was introduced in PR #11857. To fix, examine the ToolTip control's painting logic in the WinForms source code, specifically how it handles system colors. Look at the ToolTip's OnPaint or related methods to ensure it uses the dark mode color palette when appropriate. The issue mentions that the tooltip appears with a white background, so the fix likely involves updating the default background and text colors of the ToolTip.