dotnet/winforms

[Dark Mode] CheckBox/RadioButton text with FlatStyle 'System' is hard to visible after enabled SystemColorMode.Dark

Open

#11,950 opened on Aug 21, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (4,100 stars) (922 forks)batch import
area-DarkModehelp wanted

Description

.NET version

9.0.0-rc.1.24418.2 + private dlls built from winforms repo main branch

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: https://github.com/dotnet/winforms/pull/11857

Issue description

CheckBox/RadioButton text with FlatStyle 'System' is hard to visible after enabled SystemColorMode.Dark

Steps to reproduce

  1. Create a WinForms .NET application with RadioButton/CheckBox control, set RadioButton/CheckBox's FlatStyle == System
  2. Enable DarkMode by Application.SetColorMode(SystemColorMode.Dark) in Program.cs file
  3. Run the application to observe

Contributor guide

Tech stack
csharp
Domain
desktopaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsWindows Forms controlsSystemColors class
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the rendering of CheckBox and RadioButton controls when FlatStyle is System and dark mode is enabled. Review PR #11857 which introduced dark mode support. The issue likely involves the system drawn text color not being updated. Look at the OnPaint or related methods in the CheckBox/RadioButton source code. Test with the provided steps to reproduce.