dotnet/winforms

[Dark Mode]HelpProvider text color is barely visible

Open

#11,939 opened on Aug 20, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (4,100 stars) (922 forks)batch import
area-DarkModehelp wanted

Description

.NET version

9.0.0-rc.1.24418.2 + build private dll from winforms repo main branch

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: https://github.com/dotnet/winforms/pull/11857

Issue description

The text color of the helpProvider is barely visible in Dark Mode.

Dark Mode Screenshot 2024-08-20 160509 (1)

Classic Mode Screenshot 2024-08-20 160156 (1)

Steps to reproduce

  1. Create a .NET Core WinForms project
  2. Add button and helpProvider to the form
  3. Set button's properties as below
  • HelpString on helpProvider : testing 123
  • ShowHelp on helpProvider : True
  1. Build and run the project
  2. Click the button and press F1 key

Contributor guide

Tech stack
csharp
Domain
desktopaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#WinForms basicsdark mode concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the HelpProvider control in the WinForms source code. The dark mode PR #11857 may have introduced the color issue. Look for where the text color is set for HelpProvider and ensure it adapts to dark mode. Check the SystemColors or custom color handling. Review the comments on the issue for any additional guidance.