dotnet/winforms

[Dark Mode] Improve visual contrast of the LinkLabel control in dark mode

Open

#11,935 opened on Aug 20, 2024

View on GitHub
 (1 comment) (0 reactions) (2 assignees)C# (4,100 stars) (922 forks)batch import
area-DarkModehelp wanted

Description

.NET version

9.0.0-rc.1.24414.1 + build private dll form winforms repo main branch

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: https://github.com/dotnet/winforms/pull/11857

Issue description

The linklable control is not clear in the DarkMode image

Steps to reproduce

  1. Create a WinForms .NET Core application with LinkLable control.
  2. Enable DarkMode by Application.SetColorMode(SystemColorMode.Dark) in Program.cs file.
  3. Run the application.

Contributor guide

Tech stack
csharp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Windows FormsDark mode theming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the dark mode implementation introduced in PR #11857. Locate the LinkLabel control's painting logic in the source code (likely in System.Windows.Forms/src/System/Windows/Forms/LinkLabel.cs). Determine where the text color is set for dark mode and adjust the contrast ratio to meet accessibility guidelines. The issue includes a screenshot showing the current low contrast. Consider using system dark mode colors or custom colors that provide sufficient contrast. Since the issue is assigned, check if the assignees have made any progress or if there are any linked PRs.