dotnet/winforms

[Dark Mode] Control pops up dialogs and MessageBox window are not in Dark mode when DarkMode enabled

Open

#11,896 opened on Aug 16, 2024

View on GitHub
 (4 comments) (2 reactions) (0 assignees)C# (922 forks)batch import
area-DarkModehelp wanted

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (Avg merge 14d 22h) (56 merged PRs in 30d)

Description

.NET version

.NET SDK 9.0.100-rc.1.24415.1 + build private dll form winforms repo release/9.0 branch

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: https://github.com/dotnet/winforms/pull/11857

Issue description

Control pops up dialogs and MessageBox window are not in Dark mode when DarkMode enabled

ColorDialog: image

FontDialog: image

MessageBox: image

Steps to reproduce

  1. Create a WinForms .NET Core application.
  2. Enable DarkMode by Application.SetColorMode(SystemColorMode.Dark) in program.cs file.
  3. Add three button controls to the form designer.
  4. Add click events to open FontDialog, ColorDialog and MessageBox for each of the three buttons.
  5. Run the application.
  6. Click each of the three buttons and observe the color of the new dialog.

Contributor guide

Research direction
Investigate how ColorDialog, FontDialog, and MessageBox are rendered. These likely use native Windows common dialogs which may not automatically respect the dark mode setting. Look into whether WinForms provides a way to customize their appearance or if there is a need to subclass and apply dark theme manually.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#WinForms
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70