dotnet/winforms

Tests should use TheoryData<>

Open

#11,041 opened on Mar 12, 2024

View on GitHubContributor guide
 (9 comments) (0 reactions) (0 assignees)C# (922 forks)batch import
help wanted

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (PR metrics pending)

Description

Theory tests should preferably use the TheoryData<> pattern where possible. We have several hundred hits for the analyzer for this currently (xUnit1042). The analyzer is disabled in the .editorconfig file and can be commented out to hunt these down.

Once addressed we can turn this back on.

Contributor guide

Research direction
Comment out the .editorconfig setting for xUnit1042, run the analyzer to find all violations, and update each test method to use TheoryData<>.
Tech stack
csharp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#xUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75