dotnet/winforms

Annotate or get rid of the null-forgiving operators in PropertyGrid.cs and related files.

Open

#10,686 opened on Jan 18, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (922 forks)batch import
help wanted

Repository metrics

Stars
 (4,100 stars)
PR merge metrics
 (Avg merge 14d 22h) (56 merged PRs in 30d)

Description

This is a follow up on https://github.com/dotnet/winforms/pull/10110#discussion_r1360819144.

Investigate if https://github.com/dotnet/winforms/blob/f7d6850caa53f62816d977e737d6cb2a537f0d9a/src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGrid.cs#L3770 can be refactored to convince nullability analyzers that fields that are allocated in this method are not null. This would allow us to get rid of the null-forgiving operators. If not realistic, then then each null-forgiving operator should be annotated.

Contributor guide

Research direction
Investigate the code at the linked line and determine if it's possible to refactor to eliminate null forgiving operators. If not, annotate each operator with a comment explaining why it's needed.
Tech stack
csharp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git.NET nullable reference types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50