dotnet/tye

Exit code not properly logged in error message

Open

#1,138 opened on Aug 4, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (5,310 stars) (532 forks)batch import
buggood first issue

Description

Describe the bug

If a watched replica exits due to a non-zero exit code, Tye logs an error message but does not properly include the exit code.

To Reproduce

  1. Start a Tye application in "watch" mode.
  2. Kill one of the replica processes.
  3. Note watch: Exited with error code Microsoft.Tye.ProcessResult message.

Further technical details

The bug is here; only the ExitCode property should be logged, not the whole ProcessResult.

Contributor guide

Tech stack
csharp
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C# knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue is clear and directly points to the bug location at src/Microsoft.Tye.Hosting/Watch/DotNetWatcher.cs line 76. The fix is to change the logging statement to output only the ExitCode property of ProcessResult instead of the entire object. No further investigation is needed.