dotnet/runtime

Update the `EmitterUnitTests` to support an alternative disassembler

Open

#9,713 opened on Feb 12, 2018

View on GitHub
 (10 comments) (1 reaction) (0 assignees)C# (5,445 forks)batch import
area-CodeGen-coreclrenhancementhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

Currently the emitter has a set of unit tests (genAmd64EmitterUnitTests and genArm64EmitterUnitTests) which can be used for validating that the emitted byte code is correct for various scenarios.

However, this does not currently work in CoreCLR itself due to a dependency on the closed source msvcdis disassembler.

Given the number of new instructions being supported and the number of general improvements being made to the emitter for the Hardware Intrinsics feature, it would be beneficial to update these tests such that they can be run as part of CoreCLR.

category:correctness theme:testing skill-level:intermediate cost:medium impact:small

Contributor guide

Research direction
Research available open source disassemblers for AMD64 and ARM64, and update the emitter unit tests to use one of them instead of msvcdis.
Tech stack
csharp
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#GitTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50