dotnet/runtime

Sort object properties optimally in emitted config binding gen logic

Open

#92,594 opened on Sep 25, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Extensions-Configurationhelp wantedtenet-performance

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

Per @eerhardt in https://github.com/dotnet/runtime/pull/89587.

ints are pretty common in config. It might make sense to keep this near the top of the check, so we don't have to check a bunch of other (less common) types first.

@dotnet/area-extensions-configuration.

Contributor guide

Research direction
Investigate the current ordering of property type checks in emitted config binding code and propose a reordering that places common types like int near the top to reduce unnecessary checks.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#Config binding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60