dotnet/runtime

[mono] Use C11 atomics in atomic.h when building with MSVC

Open

#91,748 opened on Sep 7, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Infrastructure-monohelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

There are two things we need to do:

  1. Pass the /experimental:c11atomics to the MSVC compiler for the runtime build
  2. Use C++23 when building our C++ files (they may include "atomic.h" which includes <stdatomic.h> which errors out in MSVC in C++ mode unless you're using at least C++23)

Contributor guide

Research direction
Implement the two steps: 1) Pass /experimental:c11atomics to MSVC for runtime build. 2) Use C++23 for C++ files that include atomic.h to avoid compilation errors.
Tech stack
ccpp
Domain
build systemcompilers
Issue type
DevOps
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CC++MSVCBuild systems
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70