dotnet/runtime

Clean-up gtGetLclVarName and gtDispLclVar

Open

#77,741 opened on Nov 1, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-CodeGen-coreclrhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

To improve debugging experience we could do some clean up of this dump methods so a string is returned always and maybe use just one or clarify when it could apply one or the other.

Another suggestion is adding a padding size as @markples says in https://github.com/dotnet/runtime/pull/77700#discussion_r1010748169_

Contributor guide

Research direction
Examine the functions gtGetLclVarName and gtDispLclVar in the RyuJIT codebase. Understand their current behavior and identify areas where a consistent string return and optional padding can be added. Refer to the discussion in PR #77700 for context.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70