dotnet/runtime

Bug System.DirectoryServices.DirectorySearcher

Open

#59,756 opened on Sep 29, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.DirectoryServiceshelp wantedtest-enhancement

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

The field: internal SearchResultCollection? searchResult;

was never set. In older versions of the lib, the field was set in FindAll() method:

  SearchResultCollection resultCollection = new SearchResultCollection(root, hSearchResult, strArray, this);
  this.searchResult = resultCollection;
  return resultCollection;

Now:

        return new SearchResultCollection(clonedRoot, resultsHandle, properties, this);

As result impossible to retrieve DirsyncCookie.

Contributor guide

Research direction
Locate the FindAll method in DirectorySearcher.cs, add the missing 'this.searchResult = resultCollection;' line, and verify that DirSyncCookie is retrievable after the fix.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65