dotnet/runtime

JitDisasm disassembling arm vpop register list incorrectly

Open

#58,950 opened on Sep 10, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-CodeGen-coreclrhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

When looking at JitDisasm output today, I've noticed that the vpop was showing incorrect list of registers in the vpop instruction:

0002EC ECBD 8B04 vpop {d16-d19}

This is in fact vpop {d8,d9}

category:correctness theme:debug-dumps skill-level:beginner cost:small impact:small

Contributor guide

Research direction
Inspect the JitDisasm ARM disassembly code for the vpop instruction and correct the register list decoding.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85