dotnet/runtime

debugshim.cpp opens and gets handles to libraries, but doesn't close or store the handles

Open

#50,442 opened on Mar 30, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Diagnostics-coreclrhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

debugshim.cpp's CLRDebuggingImpl::OpenVirtualProcess method obtains handles to a bunch of libraries:

https://github.com/dotnet/runtime/blob/b23205f59ab3853e4b6b43f91a7ca3900c0cc7d0/src/coreclr/debug/shim/debugshim.cpp#L172

https://github.com/dotnet/runtime/blob/b23205f59ab3853e4b6b43f91a7ca3900c0cc7d0/src/coreclr/debug/shim/debugshim.cpp#L193

https://github.com/dotnet/runtime/blob/b23205f59ab3853e4b6b43f91a7ca3900c0cc7d0/src/coreclr/debug/shim/debugshim.cpp#L249

But those handles are not kept around and are not used to close the libraries.

Contributor guide

Research direction
Identify the open handles in debugshim.cpp and ensure they are closed using CloseHandle or stored properly for later cleanup.
Tech stack
ccpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60