dotnet/runtime

Consolidate PackageVersion properties

Open

#48,229 opened on Feb 12, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Infrastructurehelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

The PackageVersion property is currently specified four times instead of once centrally. We should consolidate that before we ship NET6 to ease servicing (especially as NET6 will be an LTS release).

This also involves consolidating the installer GetProductVersion logic with the rest of the repo: https://github.com/dotnet/runtime/blob/372248b9b4e3e7c08e0c0aa53d4a94f826fe273b/src/installer/Directory.Build.targets#L25-L138

cc @dotnet/runtime-infrastructure

Contributor guide

Research direction
Identify all places where PackageVersion is defined (e.g., Directory.Build.props, .targets files) and the installer's GetProductVersion logic. Evaluate consolidation into a single location.
Tech stack
csharp
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
MSBuild.NET build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55