dotnet/runtime

Share AssemblyName.EscapeString with UriHelper.EscapeString

Open

#44,752 opened on Nov 16, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.Reflectionhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

It seems at some point the AssemblyName version was copied from UriHelper and hasn't kept up with any changes, including its rewrite in https://github.com/dotnet/runtime/commit/94acc996414dcf6b4b60847775e0247fd959eaa8. We should get rid of the old unsafe implementation entirely and just share the code if possible. cc: @stephentoub

Contributor guide

Research direction
Compare the implementations of AssemblyName.EscapeString and UriHelper.EscapeString in the dotnet/runtime repository. Identify the old unsafe code and recent optimizations. Propose a refactoring to share the common logic.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NET SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70