dotnet/runtime

[mono] Implement pinvoke-detach-1.cs tests on Windows

Open

#43,093 opened on Oct 6, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-VM-threading-monogood first issuehelp wantedincrease-code-coverageos-windowsruntime-monotest-enhancement

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

Follow-up task for https://github.com/mono/mono/pull/20435 - the PR introduces a new set of embedding API tests that create foreign threads (threads started by native code, not by the runtime) and calling various Mono APIs in order to execute some managed code, followed by detaching from the runtime and leaving the threads running but not interacting with Mono anymore.

These tests (which on non-Windows use posix threads, mutexes and condition variables) need to be ported to Windows using the Windows APIs instead.

Contributor guide

Research direction
Study the POSIX test implementation in the referenced PR and translate it to use Windows synchronization primitives and thread APIs.
Tech stack
csharpcpp
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows APIMono embedding API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65