dotnet/runtime

TestRuntime property in test projects is static and not up-to-date

Open

#42,814 opened on Sep 28, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Infrastructure-librarieshelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

The TestRuntime property determines if code coverage should instrument System.Private.CoreLib. The TestRuntime property was added to projects that test code that resides in System.Private.CoreLib. The problem is that this property is static and hasn't be updated or added to newer projects.

This property should be replaced by checking if a ProjectReference to CoreLib exists.

Contributor guide

Research direction
Find all projects in the repo that set TestRuntime property and check if they have a ProjectReference to System.Private.CoreLib. Replace the static property with a dynamic check using MSBuild conditions or target evaluation.
Tech stack
csharp
Domain
backendtesting
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70