dotnet/runtime

Add triggering test for GC.AddMemoryPressure/GC.RemoveMemoryPressure

Open

#36,796 opened on May 21, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-GC-coreclrhelp wantedincrease-code-coverage

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

The underlying GC.AddMemoryPressure/GC.RemoveMemoryPressure implementations were updated in https://github.com/dotnet/runtime/pull/36767. The existing testing was questionable already and does nothing for this other algorithm. Deferring adding equivalent testing for now since this code path is not new but has been around since .NET Framework.

https://github.com/dotnet/runtime/blob/4eaccd61b1a2a4b078140f8b36f2b45ab5980e8e/src/coreclr/tests/src/GC/API/GC/AddMemoryPressureTest.cs#L136-L159

/cc @VSadov

Contributor guide

Research direction
Examine the existing AddMemoryPressureTest.cs file and the changes from PR #36767 to understand the new GC algorithm, then write a test that verifies the behavior of GC.AddMemoryPressure and GC.RemoveMemoryPressure under various memory pressure values.
Tech stack
csharp
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NETGC concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65