dotnet/runtime

Principal.FindByIdentity() method is extremely slow

Open

#34,598 opened on Apr 6, 2020

View on GitHub
 (10 comments) (0 reactions) (1 assignee)C# (5,445 forks)batch import
area-System.DirectoryServiceshelp wantedtenet-performance

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

In PowerShell repo we started porting Microsoft.PowerShell.LocalAccounts module to System.DirectoryServices.AccountManagement API (from p/invokes). We had to use workarounds because Principal.FindByIdentity() methods is extremely slow - up to 100x(!) vs Principal.PrincipalSearcher().

On my notebook Get-LocalUser name ported cmdlet takes 2.8 sec(!) vs 25 ms if a workaround is used.

Contributor guide

Research direction
Profile Principal.FindByIdentity to identify why it's 100x slower than PrincipalSearcher; examine the ADSI/LDAP calls and caching behavior.
Tech stack
csharp
Domain
backendapiperformance
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Performance profiling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50