dotnet/runtime

[mono] MonoImage->references reads should be atomic

Open

#32,889 opened on Feb 26, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-VM-meta-monogood first issueruntime-mono

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

As of https://github.com/dotnet/runtime/pull/32622 we will take the image lock when writing to references, but reads throughout the code are currently done directly and without locking. This should be changed to use accessor functions that read in the pointer atomically.

This isn't time-critical as I don't believe we've seen many (any?) crashes related to this, but is worth noting and changing for completeness' sake.

Contributor guide

Research direction
Investigate all places where `MonoImage >references` is read without locking and replace with atomic accessor functions. Look at the pattern used in PR #32622 for writing.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#concurrency
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60