dotnet/runtime

Building should not prefer a preview VS installation that doesn't have all the required workloads

Open

#31,446 opened on Nov 8, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Infrastructurehelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

build.cmd fails with:

EXEC : error : DIA SDK is missing at "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\DIA SDK". Make sure you selected the correct dependencies when installing Visual Studio. [C:\Users\Joseph\Source\Repos\corefx\src\Native\build-native.proj] Visual Studio Express does not include the DIA SDK. You need Visual Studio 2017 or 2019 (Community is free). See: https://github.com/dotnet/corefx/blob/master/Documentation/building/windows-instructions.md#required-software

I don't want my preview install to be as heavy as my stable install. Everything corefx needs is installed in VS 16.3.8.

Contributor guide

Research direction
Investigate how build.cmd selects a Visual Studio installation and add logic to prefer a complete installation over a preview one that lacks required workloads.
Tech stack
csharp
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Visual Studio.NET SDK
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70