dotnet/runtime

Incorrect use of DisableMediaInsertionPrompt

Open

#28,605 opened on Feb 1, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.IOhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

Unless I'm very much confused, it appears that the FileSystemEnumerator constructor uses DisableMediaInsertionPrompt incorrectly such that it will do nothing because it calls 'new DisableMediaInsertionPrompt()' instead of DisableMediaInsertionPrompt.Create().

I just happened to notice this while scrolling through the code. I don't know exactly in which situations the undesirable media prompt would occur and don't have a particular need for this to be fixed.

Contributor guide

Research direction
Locate the FileSystemEnumerator constructor and replace the direct instantiation of DisableMediaInsertionPrompt with the static Create method.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80