dotnet/runtime

ReadOnlySequence<T>.TryGet() returns empty result

Open

#27,769 opened on Oct 30, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.Memorybughelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

When calling ReadOnlySequence<T>.TryGet(ref position, out memory) with a position of sequence.End or sequence.GetPosition(size) the result is true and memory is an empty slice. As this effectively is not returning a segment or byte, is should probably return false.

As per this comment from @pakrym, I'm raising as a seperate issue.

Contributor guide

Research direction
Examine the source code of ReadOnlySequence<T>.TryGet to understand why it returns true with an empty memory when position is at the end, and determine if this is a bug or intended behavior.
Tech stack
csharp
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#ReadOnlySequence
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60