dotnet/runtime

System.Reflection.Metadata: Avoid allocations in custom attribute parser

Open

#16,724 opened on Mar 16, 2016

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.Reflection.Metadataenhancementhelp wantedtenet-performance

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

The custom attribute parser allocates an ImmutableArray for FixedArguments and NamedArguments.

We should explore options to parse these lazily and avoid the array allocation.

Contributor guide

Research direction
Profile the allocation using a memory profiler, then explore lazy initialization for FixedArguments and NamedArguments in the custom attribute parser. Consider using yielding or caching to avoid array creation.
Tech stack
csharp
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35