dotnet/runtime

Improve custom attribute decoding tests

Open

#16,552 opened on Mar 1, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.Reflection.Metadatahelp wantedtest-enhancement

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

Currently, due to lack of time, some tests just check that we don't throw. A better approach would probably be to generically compare reflection CustomAttributeData to S.R.M CustomAttributeValue for every test attribute applied.

Also, there needs to be test cases for malformed custom attributes. Test coverage is at ~70% now with only positive cases.

Contributor guide

Research direction
Review existing custom attribute tests. Add comparisons between reflection CustomAttributeData and CustomAttributeValue. Create test cases for malformed custom attributes.
Tech stack
csharp
Domain
testing qa
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65