dotnet/runtime

Respond to PR code review comments for ported library System.Security.AccessControl

Closed

#15,934 opened on Dec 14, 2015

View on GitHubContributor guide
 (9 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.Securityenhancementhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

@GiriSr as the owner of the System.Security.AcessControl library can you please have a look through the code review comments provided in https://github.com/dotnet/corefx/pull/4977 and address them appropriately.

Contributor guide

Research direction
Review the code review comments in the linked PR (dotnet/corefx#4977) to understand the feedback. Check if the ported System.Security.AccessControl library in dotnet/runtime already addresses these comments or if they are still unresolved. Determine the appropriate response for each comment, which may include making code changes or providing explanations. Consult the maintainer (@GiriSr) if needed for clarification.
Tech stack
csharp
Domain
backendsecurity
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#System.Security.AccessControlCode review
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25