dotnet/runtime

Cleanup RegSet::verifyRegUsed

Open

#13,508 opened on Sep 30, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-CodeGen-coreclrhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

verifyRegUsed() is supposed to be an assertion that the register is marked as used. However, its implementation is changing the register mask instead. This needs to be clean up.

dotnet/coreclr#18296 was an attempt to fix it, but it was wrong and incomplete. We need a better solution than that.

category:implementation theme:jit-coding-style skill-level:beginner cost:small

Contributor guide

Research direction
Examine the verifyRegUsed function in the JIT compiler codebase to ensure it performs an assertion without modifying the register mask. Review the previous attempt in dotnet/coreclr#18296 to understand the pitfalls.
Tech stack
csharp
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85