[ci-scan-feedback] harden fixer self-dedup with a non-integrity-gated branch-list backstop
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Read .github/workflows/ci-failure-fix.md around lines 166, 253, and 263, starting with the existing deduplication checks and branch-list handling. Update the checks so matching ci-fix branches remain authoritative when PR search results are filtered, and require the documented branch-token format. Done means the fixer skips an existing KBE branch even when the PR map is unavailable.
Written by the indexing model from the issue text.
Description
Triggering signals
- (#131981, MEMBER
kotlarmilos: "Duplicate https://github.com/dotnet/runtime/pull/131515." — a[ci-fix]help PR that duplicated the fixer's own earlier PR #131515; both live onci-fix/131382-...branches and both link KBE #131382, https://github.com/dotnet/runtime/pull/131981) - (rubric finding:
list_branchesondotnet/runtimeshows twoci-fix/131382-helix-pythonpath-windowsshell-*branches, plusci-fix/android-x509-...-128890-...andci-fix/reflection-unwrap-tie-128766-...where the KBE id is mid-name, not a prefix — so Step 3'sci-fix/<kbe>-prefix key never matched them) - (rubric finding:
githubMCPsearch_pull_requests/search_issuesfor[ci-scan]/[ci-fix]artifacts returns[Filtered]under the integrity gate — 71[ci-scan]items filtered this tick — silently emptying the dedup PR map, whilelist_branchesreturns unfiltered results)
Proposed edits
- (
.github/workflows/ci-failure-fix.md:166— add a non-integrity-gatedlist_branchesdedup backstop with a position-independent(^|-)ci-fix/(.*-)?<kbe>(-|$)token match; directly closes the gap that let #131981 duplicate #131515) - (
.github/workflows/ci-failure-fix.md:166— update dedup check 1 to treat either a PR-map hit or a matching branch as authoritative, even when the PR search is[Filtered]) - (
.github/workflows/ci-failure-fix.md:253,263— require the numeric KBE id to be the first hyphen-delimited branch token in Steps 5.3/5.4 so the branch-list key is reliable going forward)
Expected behavior change
On the next fixer run, before opening a [ci-fix] PR the agent enumerates repository branches (which the integrity gate does not filter) and skips any KBE that already has a ci-fix/...<kbe>... branch, regardless of where the id sits in the name. This prevents the recurring failure mode where an integrity-[Filtered] PR search hid the fixer's own prior PR and it opened a duplicate for the same KBE (#131981 vs #131515).
[!NOTE]
This PR description was generated by an AI agent (GitHub Copilot).
Generated by CI Outer-Loop Failure Scanner — Feedback · opus48 · 541.6 AIC · ⌖ 26.5 AIC · ⊞ 20.6K · ◷
[!NOTE]
This was originally intended as a pull request, but the git push operation failed.Original error: The process '/usr/bin/git' failed with exit code 1
Workflow Run: View run details and download bundle artifact
The bundle file is available in the
agentartifact in the workflow run linked above.
To create a pull request with the changes:
# Download the artifact from the workflow run
gh run download 33312726322 -n agent -D /tmp/agent-33312726322
# Fetch the bundle into a temporary ref, then update the local branch
git fetch /tmp/agent-33312726322/aw-ci-scan-feedback-dedup-branchlist.bundle refs/heads/ci-scan-feedback-dedup-branchlist:refs/bundles/create-pr-ci-scan-feedback-dedup-branchlist-ff21e57fce465c60-95c03704
git update-ref refs/heads/ci-scan-feedback-dedup-branchlist-ff21e57fce465c60 refs/bundles/create-pr-ci-scan-feedback-dedup-branchlist-ff21e57fce465c60-95c03704
git checkout ci-scan-feedback-dedup-branchlist-ff21e57fce465c60
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d refs/bundles/create-pr-ci-scan-feedback-dedup-branchlist-ff21e57fce465c60-95c03704
# Push the branch to origin
git push origin ci-scan-feedback-dedup-branchlist-ff21e57fce465c60
# Create the pull request
gh pr create --title '[ci-scan-feedback] harden fixer self-dedup with a non-integrity-gated branch-list backstop' --base main --head ci-scan-feedback-dedup-branchlist-ff21e57fce465c60 --repo dotnet/runtime
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 589
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area-VM-meta-mono untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
ci-failure-cause test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:auth FE mvp P3
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
klasolsson81/jobbliggaren#1788 ·