Remove Grace from external DI container conformance tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- csharp
- Domain
- documentation, testing
Research direction
Start with Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csproj, Grace.cs, and the Microsoft.Extensions.DependencyInjection README named in the steps. Remove the Grace package reference and source file, remove its README entry, and verify the external container tests and documentation no longer list Grace; the linked ASP.NET Core docs update is a separate task.
Written by the indexing model from the issue text.
Description
Drop Grace from Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests and the README's list of recognised third-party containers. Grace has now been explicitly sunset by its author. From the Grace README:
After many years of development I am making the decision to sunset Grace. While it's still possible to use Grace, the evolution of the built-in dependency injection container has made Grace less relevant. […] You can check out my next project that builds on top of the existing Microsoft DI container: https://github.com/ipjohnson/DependencyModules.
| Signal | Value |
|---|---|
| Deprecation notice committed | 2025-02-08 |
| Last non-README commit | January 2023 |
| Last open PR ("Support for new .net 8.0 features") | unmerged since Jun 2024 |
Grace.DependencyInjection.Extensions (the MS.DI adapter we depend on) |
no release since 7.1.0 |
Grace.cs already skips 3 spec tests + opts out of IServiceProviderIsService |
yes |
Steps
- Remove the
Grace.DependencyInjection.ExtensionsPackageReferencefrom
src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.External.Tests/Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csproj. - Delete
src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.External.Tests/Grace.cs. - Remove the Grace bullet from
src/libraries/Microsoft.Extensions.DependencyInjection/README.md. - Update Microsoft docs section "Default service container replacement" which still lists Grace; that page lives in
dotnet/AspNetCore.Docsand should be updated separately.
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 633
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows area-Infrastructure untriaged
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
-
agentic-workflows area-Infrastructure untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows area-Infrastructure untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Similar issues
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
ci-failure-cause test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:auth FE mvp P3
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
klasolsson81/jobbliggaren#1788 ·