[Workloads] Move setup and aliasing out of Versions.props

Open Beginner friendly
#122,354 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
build-system

Research direction

Start by inspecting the workload's Versions.props and the related Directory.Build.props files. Compare the referenced dotnet/sdk example to understand where setup and aliasing belong, then verify that the moved properties retain the correct values when building from source. Done means the setup and aliasing no longer read another property from Versions.props.

Written by the indexing model from the issue text.

Description

area-Workloads

Move

Note that reading from another property in Versions.props is an anti-pattern as this will have the wrong value when building from source. That overrides versions after the Versions.props import. We usually put things that read from Version.Details.props / Versions.props into Directory.Build.props.

Might not matter here if this path isn't exercised in source-build but wanted to mention it.

See https://github.com/dotnet/sdk/blob/0d31ba892465268a030b3563df0bddef39855f6e/Directory.Build.props#L97 for an example

Originally posted by @ViktorHofer in #121853

Dominant language
C#
Stars
18.3k
Forks
5.6k
Avg merge
2d 19h
Merged PRs (30d)
589

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.