dotnet/runtime

Add logic (possibly just an assert) that will catch cases where we try to emit an instruction that is not supported by the underlying CPU

Open

#11,578 opened on Nov 29, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C# (5,445 forks)batch import
area-CodeGen-coreclrenhancementhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

As with https://github.com/dotnet/coreclr/issues/21105, there are some cases where we try to emit an encoding of an instruction that is not supported by the underlying CPU.

We should add some logic to the emitter that will help catch this type of error.

category:implementation theme:jit-coding-style skill-level:beginner cost:small impact:small

Contributor guide

Research direction
Examine the JIT emitter code in dotnet/runtime, particularly the method responsible for emitting instructions, and locate where an assertion can be added to verify CPU support. Refer to dotnet/coreclr issue #21105 for context.
Tech stack
csharp
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75