dotnet/runtime

Clean up genClearStackVec3ArgUpperBits

Open

#10,878 opened on Aug 10, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-CodeGen-coreclrenhancementhelp wantedos-linux

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

This is a copy of dotnet/runtime#5897. For some reason it wasn't possible to update the description of that issue.

genClearStackVec3ArgUpperBits can be split and implemented in genFnPrologCalleeRegArgs() for argument registers and genEnregisterIncomingStackArgs() for stack arguments.

Related PR: dotnet/coreclr#4963

category:implementation theme:codegen skill-level:intermediate cost:small

impact:small

Contributor guide

Research direction
Examine the current implementation of genClearStackVec3ArgUpperBits in the codebase. Understand its purpose and the two functions genFnPrologCalleeRegArgs and genEnregisterIncomingStackArgs. Plan to split the code accordingly and test.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#code generation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50