dotnet/runtime

[ARM32] Split CodeGen::instGen_Set_Reg_To_Imm into relocatable immediate/non-relocatable immediate cases

Open

#10,755 opened on Jul 23, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
arch-arm32area-CodeGen-coreclrenhancementhelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

As suggested in https://github.com/dotnet/coreclr/pull/19013#discussion_r204171338 the next step complement to dotnet/coreclr#19013 should be splitting instGen_Set_Reg_To_Imm in src/jit/codegenarm.cpp into two separate functions:

  1. the one that accepts only relocatable immediate (as a BYTE* addr);
  2. another one that accepts non-relocatable immediate (as a target_ssize_t imm).

@BruceForstall Please feel free to add if I missed anything

category:implementation theme:emitter skill-level:beginner cost:small impact:small

Contributor guide

Research direction
Examine the current implementation of `instGen Set Reg To Imm` in `src/jit/codegenarm.cpp`. Understand the difference between relocatable and non relocatable immediates. Split the function into two: one that takes a `BYTE* addr` for relocatable immediates and another that takes a `target ssize t imm` for non relocatable ones. Ensure all call sites are updated accordingly.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++JIT compiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80